Skip to content

Conversation

@stackit-pipeline
Copy link
Contributor

Generated from GitHub run 21351823899

Comment on lines +210 to +213
- **Breaking Change:** `ListFlavors` renamed to `FlavorsList`
- **Feature:** Add support for `FeatureToggle`s to `PatchInstancePayload` and `Instance` structs
- **Breaking Change:** `ListInstances` renamed to `GetInstances`.
- **Breaking Change:** model `ListInstances` renamed to `InstanceList`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These breaking changes should be avoided because the previous names were align with our naming conventions. https://developers.stackit.schwarz/domains/customer-touchpoints/developer-tools/adr/uniformity-layer/#schemas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the team doesn't want to rename the schema at every single place manually, they can also just use the x-stackit-sdk annotiation, to rename the Methods and schemas just for the SDK generation https://developers.stackit.schwarz/domains/core-platform/api-management/api-gateway/features/annotations/#x-stackit-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants